Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Car Booking App Available Cars Screen #105

Closed
wants to merge 1 commit into from
Closed

Car Booking App Available Cars Screen #105

wants to merge 1 commit into from

Conversation

mdnazisharman2803
Copy link
Contributor

  • Created Available Cars Screen and managesd state using provider, used list view builder to show items.
  • For the issue Car Booking App #102
  • Here is the output below:

Screenshot (730)

  • Scrolling down to make sure if everything is
    Screenshot (729)

@mdnazisharman2803
Copy link
Contributor Author

@naveeramesh @Jaideep25-tech please approve this pr thanks

naveeramesh
naveeramesh suggested changes May 29, 2022
View reviewed changes
Copy link
Contributor

@naveeramesh naveeramesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add bottom bar or make sure the drawer bar works with certain items.

@mdnazisharman2803
Copy link
Contributor Author

Add bottom bar or make sure the drawer bar works with certa

Add bottom bar or make sure the drawer bar works with certain items.

Yes mam this is available cars screen and I've added drawer icon on top left that I'll implement along with details of available cars in the next pr related to this issue

naveeramesh
naveeramesh suggested changes May 29, 2022
View reviewed changes
Copy link
Contributor

@naveeramesh naveeramesh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the background colour to white and do some extra ui changes to make the home screen standard.
Refer this: https://dribbble.com/shots/15249351-Buy-Sell-Service-Mobile-App

@mdnazisharman2803
Copy link
Contributor Author

Ok mam, so i should close this pr, because I have deleted the folder from local drive.. So if I make changes now, will create merge conflicts so I should close this

@naveeramesh
Copy link
Contributor

Ok mam, so i should close this pr, because I have deleted the folder from local drive.. So if I make changes now, will create merge conflicts so I should close this

You don't need to close the pr make changes and give a seperate PR.

@mdnazisharman2803
Copy link
Contributor Author

Ok mam, so i should close this pr, because I have deleted the folder from local drive.. So if I make changes now, will create merge conflicts so I should close this

You don't need to close the pr make changes and give a seperate PR.

But that will create a merge conflict as will be making changes in the same folderbecause it's not yet merged.
It's ok just need color changes and modifications, will close this and make new won't take more time

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveeramesh naveeramesh naveeramesh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdnazisharman2803 @naveeramesh